Skip to content

fix(plugin-vue): don't inline ts scripts during build#1

Closed
jods4 wants to merge 1 commit intomainfrom
issue-7908
Closed

fix(plugin-vue): don't inline ts scripts during build#1
jods4 wants to merge 1 commit intomainfrom
issue-7908

Conversation

@jods4
Copy link
Owner

@jods4 jods4 commented Apr 26, 2022

Partial revert of 93d9a2d
When building, TS scripts must not be inlined so that loaders (e.g. rollup-plugin-typescript2) are correctly applied.

Fixes vitejs#5044, vitejs#5795, vitejs#7908


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Partial revert of 93d9a2d
When building, TS scripts must not be inlined so that loaders (e.g. rollup-plugin-typescript2) are correctly applied.

Fixes vitejs#5044, vitejs#5795, vitejs#7908
@jods4 jods4 closed this Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[@vitejs/plugin-vue] Type definition generation in library mode is broken

1 participant